Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filename wrap in status window #544

Merged
merged 5 commits into from
Feb 28, 2022

Conversation

samwiseg0
Copy link
Contributor

@samwiseg0 samwiseg0 commented Feb 28, 2022

This issue has bothered me for some time and I figured I would attempt to fix it. If this is not the "best" way to do this please let me know. Tested in several browsers and iOS 15.

Before the changes:
Screen Shot 2022-02-27 at 8 07 15 PM
Screen Shot 2022-02-27 at 8 07 29 PM

After the changes:
Screen Shot 2022-02-27 at 8 04 53 PM
Screen Shot 2022-02-27 at 8 04 39 PM

Signed-off-by: Phillip Hernandez [email protected]

@matmen matmen added FR - Enhancement New feature or request UI - QoL Improvements to the UI labels Feb 28, 2022
@matmen matmen added this to the Release: 1.18 milestone Feb 28, 2022
@pedrolamas
Copy link
Member

Though I agree with you that the initial approach is quite flawed (and quite honestly, doesn't even seem to be doing a proper job), I am checking on the implications of such a change on a component that is used for more things than just displaying filenames!

Specifically, if there is an M117 with a long text, it would also be truncated on letter instead of word, but that would look quite odd for that case... so a localized change for the filename only might make more sense here.

@samwiseg0
Copy link
Contributor Author

samwiseg0 commented Feb 28, 2022

Though I agree with you that the initial approach is quite flawed (and quite honestly, doesn't even seem to be doing a proper job), I am checking on the implications of such a change on a component that is used for more things than just displaying filenames!

Specifically, if there is an M117 with a long text, it would also be truncated on letter instead of word, but that would look quite odd for that case... so a localized change for the filename only might make more sense here.

That makes sense. I had not considered M117 messages as I do not use it.

I am no css expert by any means and unsure of what would need to be done to make that specific to just the file name.

@pedrolamas
Copy link
Member

Not only M117 apparently...

image

I am no css expert by any means and unsure of what would need to be done to make that specific to just the file name.

I think I can help with that! 🙂

Signed-off-by: Pedro Lamas <[email protected]>
@samwiseg0
Copy link
Contributor Author

Tested your changes. They work perfectly! Thank you for your time and effort.
Screen Shot 2022-02-28 at 12 05 36 PM

Copy link
Member

@pedrolamas pedrolamas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matmen matmen merged commit a034190 into fluidd-core:develop Feb 28, 2022
@samwiseg0 samwiseg0 deleted the fix/filename_wrap branch February 28, 2022 20:48
@pedrolamas pedrolamas modified the milestones: Release: 1.18, 1.17.1 Mar 1, 2022
matmen pushed a commit to matmen/fluidd that referenced this pull request Jun 27, 2022
Signed-off-by: Phillip Hernandez <[email protected]>
Co-authored-by: Pedro Lamas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FR - Enhancement New feature or request UI - QoL Improvements to the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants